-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update package dependencies #160
Conversation
I've no idea why CI is failing on |
LGTM! Ci:tests pass locally for me as well. |
I'm running node 12.14.1 and pnpm 4.7.1 on Debian 9.11 |
OK thanks for checking. Since we've got a failure verified, I'm going to revert updates to that one and try to tackle it in a separate PR. |
c375173
to
ff7d1f3
Compare
@wuweiweiwu @Kocal I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! very small comment
packages/inject/package.json
Outdated
"magic-string": "^0.25.2", | ||
"rollup-pluginutils": "^2.6.0" | ||
"@rollup/pluginutils": "^3.0.4", | ||
"estree-walker": "1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be a version lock on 1.0.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit
Co-Authored-By: Tiger Oakes <toakes@mozilla.com>
Rollup Plugin Name: many
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This is a repo-wide dependency update to get packages off of deprecated versions of plugins.
This PR should be straight merged and not squash merged.
Individual publishes for packages that match
chore({name}): update dependencies
will follow after the merge.pluginutils
was left out as it won't build with the new version ofcommonjs
due to a regression (which I opened another issue for)